Fix analytics for non-existent URLs

NFarrington · Aug 23, 2019 · 79de57b · 79de57b
1 parent 78defd3
commit 79de57b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/app/Http/Middleware/LogRequests.php b/app/Http/Middleware/LogRequests.php
@@ -43,12 +43,13 @@ public function terminate(Request $request, Response $response)
     {
         /** @var Url $url */
         $url = $request->session()->pull('short.url');
+        $analyticsDisabled = $url && $url->analytics_disabled;
 
-        if (!$url->analytics_disabled) {
+        if (!$analyticsDisabled) {
             $serverData = $this->filterFillable($_SERVER);
             UrlAnalytics::create([
                 'user_id' => Auth::check() ? Auth::user()->id : null,
-                'url_id' => $url->id,
+                'url_id' => $url ? $url->id : null,
                 'request_time' => $_SERVER['REQUEST_TIME'],
                 'http_host' => $request->root(),
                 'http_referer' => $request->headers->get('referer'),