Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging direct mort condition check bug #1289

Open
XiulinGao opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1291
Open

Logging direct mort condition check bug #1289

XiulinGao opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1291

Comments

@XiulinGao
Copy link
Contributor

if (cur_harvest_tag == 0) then

I was running the logging module with area-based logging approach and found no direct mortality at all. I tracked down to this line of code. As for area-based logging, cur_harvest_tag is set to 2, thus there will never be direct logging mortality resulted from it.

cur_harvest_tag = 2

this condition check should be (cur_harvest_tag .eq. 0 .or. cur_harvest_tag .eq. 2).

@sshu88
Copy link
Contributor

sshu88 commented Nov 19, 2024

This tag was designed to be 0 for C-based harvest if biomass match the demand or area-based harvest. Later I have changed this to 2 for area-based harvest thus it can bypass some of the harvest debt calculation in patch dynamics. Thanks for the correction. Will contact others and submit PR for correction.

sshu88 added a commit to sshu88/fates that referenced this issue Nov 20, 2024
Fix the issue of no wood product when forced by area-based harvest. 
NGEET#1289
@sshu88 sshu88 linked a pull request Nov 20, 2024 that will close this issue
4 tasks
@glemieux glemieux linked a pull request Dec 3, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❕Todo
Development

Successfully merging a pull request may close this issue.

2 participants