Bug fix for issue #1289 #1291
Open
Bug fix for issue #1289 #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue of no wood product when forced by area-based harvest. NGEET#1289
XiulinGao
approved these changes
Dec 2, 2024
ckoven
reviewed
Dec 2, 2024
biogeochem/EDLoggingMortalityMod.F90
Outdated
| @@ -291,7 +291,7 @@ subroutine LoggingMortality_frac( pft_i, dbh, canopy_layer, lmort_direct, & | |||
| ! transfer of area to secondary land is based on overall area affected, not just logged crown area | |||
| ! l_degrad accounts for the affected area between logged crowns | |||
| if(prt_params%woody(pft_i) == itrue)then ! only set logging rates for trees | |||
| if (cur_harvest_tag == 0) then | |||
| if (cur_harvest_tag == 0 .or. cur_harvest_tag == 2) then | |||
There was a problem hiding this comment.
HI @sshu88 -- would it be possible to replace these integers that you are comparing cur_harvest_tag to, here and elsewhere, with named integer constants that describe more clearly what these conditions refer to?
There was a problem hiding this comment.
Nice suggestion! I updated the code.
Use named integer constants for "harvest_tag"
Define named constants for "harvest_tag"
|
Regression testing underway on derecho. |
Two-stream singularity correction update This implements a more comprehensive avoidance of singularities with two-stream radiation across bands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of no wood product when forced by area-based harvest. #1289
Description:
Collaborators:
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: