Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values of fates_hydro_solver and fates_hydro_vg_alpha_node #1263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jennykowalcz
Copy link

@jennykowalcz jennykowalcz commented Oct 14, 2024

This PR changes the default values of the parameters fates_hydro_solver and fates_hydro_vg_alpha_node.

Description:

The default for hydro_solver is changed from 1 (Taylor 1D) to 2 (Picard 2D) to increase the hydro model stability and avoid having it crash under very dry conditions. See discussion 1187.

The default for fates_hydro_vg_alpha_node is changed from 0.005 to 0.12 MPa^-1. The previous small value led to unrealistic values of stem conductivity fraction over the Amazon Basin when using the van Genuchten hydraulic transfer function for plants (i.e. fates_hydro_htftype_node = 2 for all organs). See issue 1228. The new larger value was chosen to approximate the results from the default TFS hydraulic transfer function (fates_hydro_htftype_node = 1) with default hydro parameter values.
vg_alpha_test

Disclaimer: I have not tested this is a global run, just regionally over tropical South America.

Collaborators:

@rgknox

Expectation of Answer Changes:

The change to fates_hydro_vg_alpha_node will change model output significantly if you are using the van Genuchten hydraulic transfer function.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@jennykowalcz jennykowalcz added the parameter file Pertaining to changes to the FATES parameter file label Oct 14, 2024
@jennykowalcz jennykowalcz marked this pull request as ready for review October 22, 2024 17:52
@rgknox
Copy link
Contributor

rgknox commented Oct 28, 2024

This is great @jennykowalcz , we will get some review going on this

@rgknox rgknox self-requested a review October 30, 2024 15:02
@rgknox
Copy link
Contributor

rgknox commented Oct 30, 2024

@jennykowalcz There is agreement to switch to Picard, and the updated VG parameters yield better results in the tropics. Have you tested VG and/or found if it's a stable alternative outside the tropics? I see that you also updated the VG parameters for the non-tropical PFTs as well. Are the changes for those also a stability improvement?

@jennykowalcz
Copy link
Author

@jennykowalcz There is agreement to switch to Picard, and the updated VG parameters yield better results in the tropics. Have you tested VG and/or found if it's a stable alternative outside the tropics? I see that you also updated the VG parameters for the non-tropical PFTs as well. Are the changes for those also a stability improvement?

Hi @rgknox ! I have not done any testing outside the SA tropics. I can do a quick set of global low-res runs with the current and new parameter files. I updated the values for all PFTs because all of the other hydro parameters have the same values for all PFTs.

@jennykowalcz
Copy link
Author

Some results from the global runs so far. These are in no-comp mode with compset IELMFATES with a 4x5 degree grid.
Screenshot 2024-11-08 at 7 19 32 AM

This is from 100 model years, so vegetation is not at equilibrium yet. Most of the biomass is in broadleaf tropical trees (evergreen and hydro-deciduous), followed by broadleaf evergreen extratropical trees.
Screenshot 2024-11-08 at 7 20 26 AM

Side note, it is very cool that FATES-Hydro is working globally out of the box! 😃

@glemieux
Copy link
Contributor

@jennykowalcz just to clarify, "out of the box" refers to the TFS default, correct? Also, could you elaborate on the settings for each test regarding the organs?

Do you recommend going to vG as default and for which flux?

@jennykowalcz
Copy link
Author

jennykowalcz commented Nov 11, 2024

@jennykowalcz just to clarify, "out of the box" refers to the TFS default, correct? Also, could you elaborate on the settings for each test regarding the organs?

Do you recommend going to vG as default and for which flux?

Hi @glemieux! No, I think TFS should be kept as the default hydraulic transfer function (fates_hydro_htftype_node = 1, 1, 1, 1 ;).

By "out of the box" I meant with the default parameter file with all PFTs, and yes, TFS hydraulic transfer function.

For the test here I ran three simulations: 1) TFS hydraulic transfer function (for all hydro organs), 2) vG hydraulic transfer function (for all hydro organs) with vg_alpha = 0.12 for all PFTs ("vG, new") and 3) vG hydraulic transfer function (for all hydro organs) with vg_alpha as set in the previous default parameter file for all PFTs (the value is 0.0005 for PFTs 1-5 and 0.005 for the other PFTs.) The goal of the parameter update to vg_alpha is just to get results closer to what you'd get with TFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameter file Pertaining to changes to the FATES parameter file
Projects
Status: Final Testing
Development

Successfully merging this pull request may close these issues.

4 participants