Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land Use Fixes #1273

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Land Use Fixes #1273

wants to merge 12 commits into from

Conversation

ckoven
Copy link
Contributor

@ckoven ckoven commented Oct 29, 2024

I've been running into various errors in transient historical runs with full land use. The branch I am using has various things that aren't on main yet, so I thought I'd cherry-pick just the land-use-relevant things into a separate branch, so that if others want to use them they can.

In addition to the bugfixes, this deletes a bunch of history variables that apply only to secondary lands, and replaces a subset of them (biomass, burned area, GPP, NPP) with ones that have a land-use dimension to them.

Note that there is also one ELM-side bug fix as well, at the commit pointed to in #1260.

Description:

Collaborators:

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@ckoven ckoven requested a review from samsrabin October 29, 2024 23:16
Copy link
Contributor

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, Charlie, thanks! I just have a few minor notes that I'll propose (untested) fixes to in a PR shortly.

biogeochem/EDLoggingMortalityMod.F90 Outdated Show resolved Hide resolved
biogeochem/EDLoggingMortalityMod.F90 Outdated Show resolved Hide resolved
Minor changes to landuse_fixes branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under Review
Development

Successfully merging this pull request may close these issues.

3 participants