Prevent creating malformed version #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let assume that I run a cmake with option `-DNETGEN_VERSION_GIT="v6.2.2204"` (or without this option at all) to avoid calling `git` which won't work when I've downloaded sources from GitHub as `.zip` file. If I try to compile sources and run it, it fails with error like: ``` libc++abi: terminating with uncaught exception of type std::invalid_argument: stoi: no conversion ``` after some digging I've discovered that `netgen_version.hpp` looks like: ``` #ifndef NETGEN_VERSION_HPP_INCLUDED #define NETGEN_VERSION_HPP_INCLUDED #define NETGEN_VERSION "6.2.0-v6.2.0.0-v6.2.0.0" #define NETGEN_VERSION_MAJOR 6 #define NETGEN_VERSION_MINOR 2 #define NETGEN_VERSION_PATCH 0 #define NETGEN_VERSION_TWEAK v6.2.0.0 #define NETGEN_VERSION_HASH "v6.2.0.0" #endif // NETGEN_VERSION_HPP_INCLUDED ``` This is happened because `string(REGEX REPLACE` copied original string to target and replaces it by regex. If regex doesn't match => it still copied an original value. So, this commit prevented this mess from happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let assume that I run a cmake with option
-DNETGEN_VERSION_GIT="v6.2.2204"(or without this option at all) to avoid callinggitwhich won't work when I've downloaded sources from GitHub as.zipfile.If I try to compile sources and run it, it fails with error like:
after some digging I've discovered that
netgen_version.hpplooks like:This is happened because
string(REGEX REPLACEcopied original string to target and replaces it by regex. If regex doesn't match => it still copied an original value.So, this commit prevented this mess from happened.