Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link checker output #298

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix link checker output #298

merged 1 commit into from
Nov 3, 2023

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Nov 2, 2023

The workflows didn't output the broken links anymore. Now they do again (I hope).

@egpbos egpbos requested a review from c-martinez November 2, 2023 19:48
@egpbos egpbos force-pushed the fix-link-checker-output branch from 543022b to f34e997 Compare November 2, 2023 19:49
The workflows didn't output the broken links anymore. Now they do.
@egpbos egpbos force-pushed the fix-link-checker-output branch from f34e997 to a407d2c Compare November 2, 2023 19:55
@egpbos
Copy link
Member Author

egpbos commented Nov 2, 2023

This action output shows that it now works again: https://github.com/NLeSC/guide/actions/runs/6737597584/job/18315399946?pr=298

Scherm­afbeelding 2023-11-02 om 21 01 07

Removing again the temporary commit that was used to activate checking all links in the PR.

@egpbos egpbos force-pushed the fix-link-checker-output branch from d601773 to a407d2c Compare November 2, 2023 20:02
@egpbos egpbos requested a review from bouweandela November 2, 2023 20:02
@egpbos egpbos mentioned this pull request Nov 2, 2023
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did notice rather a lot of deprecation warnings in the output where it actually checked the links though, maybe it's time we update the version of some of these actions?

@egpbos egpbos merged commit 10df93d into main Nov 3, 2023
@egpbos egpbos deleted the fix-link-checker-output branch November 3, 2023 08:31
@egpbos
Copy link
Member Author

egpbos commented Nov 3, 2023

Good point @bouweandela: #304.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants