Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version specified not used in conf.py #587

Closed
1 task done
vedran-kasalica opened this issue Aug 27, 2024 · 3 comments
Closed
1 task done

Package version specified not used in conf.py #587

vedran-kasalica opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
generated-package Related to the generated package, i.e. after running cookiecutter

Comments

@vedran-kasalica
Copy link
Member

Checklist before submitting a bug report

  • I have checked the existing issues and couldn't find an issue about this bug.

Bug details

Describe the bug

When using the template the user is asked to fill in the software version, author name, etc. However, the version is not used in conf.py. For example, if we specify the version to 0.2.2, .copier-answers.yml contains the correct version: 0.2.2, while conf.py contains version = "0.1.0".

In addition, Notice contains only the text "This product includes workflomics_benchmarker, software developed by ." It could include the specified author's name.

To Reproduce

Steps to reproduce the behavior:

  1. install copier using pipx
  2. run copier copy --vcs-ref=HEAD https://github.com/nlesc/python-template.git . (applying to existing code)
  3. Select minimal template
  4. Specify version to 0.2.2
  5. See generated files conf.py and Notice

Expected behavior

I would expect the version in conf.py to be version = "0.2.2".

I would expect the notice to reads "This product includes workflomics_benchmarker, software developed by Author Name."

@vedran-kasalica vedran-kasalica added the generated-package Related to the generated package, i.e. after running cookiecutter label Aug 27, 2024
@vedran-kasalica vedran-kasalica changed the title Version specified not used in conf.py Package version specified not used in conf.py Aug 27, 2024
@bouweandela
Copy link
Member

It would be nice to have some automation around the version number, by using something like setuptools-scm, or bump-my-version, or versioneer, or see here for some more discussion.

@lyashevska lyashevska self-assigned this Aug 27, 2024
@lyashevska lyashevska mentioned this issue Aug 27, 2024
10 tasks
@lyashevska
Copy link
Member

A separate issue is created to address #607

@fdiblen
Copy link
Member

fdiblen commented Aug 27, 2024

fixed by #606

@fdiblen fdiblen closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generated-package Related to the generated package, i.e. after running cookiecutter
Projects
None yet
Development

No branches or pull requests

4 participants