Remove dead code

[304NotModified]

Remove dead code by falling back to Debug

[codecov-io]

Current coverage is 100.00%

Merging #8 into master will increase coverage by +4.26% as of 583f2a9

@@            master      #8   diff @@
======================================
  Files            2       2       
  Stmts           47      42     -5
  Branches         3       3       
  Methods          0       0       
======================================
- Hit             45      42     -3
+ Partial          1       0     -1
+ Missed           1       0     -1

Review entire Coverage Diff as of 583f2a9

Powered by Codecov. Updated on successful CI builds.

[304NotModified]

@pysco68

Your opinion on this change please :)

[pysco68]

Removing the code in which we shouldn't end up is certainly a good idea, however I'm not so confident with dropping the log level to "debug" by default as most Logging (NLog and others) configurations I saw up to now are not keeping that level / writing it somewhere.... thus the "danger" of having potentially important messages dropped

But you certainly have more experience in that field

[304NotModified]

configurations I saw up to now are not keeping that level / writing it somewhere.... thus the "danger" of having potentially important messages dropped

Well before it was 'ArgumentOutOfRangeException` instead of debug level as fallback? (in the high unlikely case) - so we lose less messages?

[pysco68]

Sure, didn't want to say my initial implementation is really "better" but I tend to stick to the principle "let it crash" in the meaning that if something unexpected happens (some logging level that wasn't known to me at time of programming pops up) I prefer (from a DevOps POV) that the application tells it to me in the most obvious way

[pysco68]

But, anyhow that was my standard policy, but I'm not forcing it. If the other way around is the standard in the NLog project I've got no problem sticking to that, I wanted just to point out that "Debug" as a target level feels weird to me;

I'd tend to put the flags as high as possible in the case of something unexpected, that's all

[304NotModified]

But, anyhow that was my standard policy, but I'm not forcing it. If the other way around is the standard in the NLog project I've got no problem sticking to that, I wanted just to point out that "Debug" as a target level feels weird to me;

Thanks for the feedback @pysco68. It was easy to create an unit test with the invalid value, hence an exception isn't bad.

superseded by #9