consolidate user_add_params #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliestock
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Hello @yichengt900 and @theresa-morrison - this looks great to me. Forge ahead!
theresa-morrison
approved these changes
Dec 6, 2024
|
Thanks @yichengt900! These changes look like what we discussed and it is good that they are not changing answers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #104 and includes the following updates:
cobalt_param_doc.F90.user_add_paramscall fromgeneric_COBALT_init.get_paramcalls within theuser_add_paramssubroutine to enhance its robustness and maintainability.These changes have been validated through 1D regression testing as well as
NWA12,NEP10, andOM4p25COBALT regression tests, confirming no impact on baseline results. However, due to the reorganization ofget_paramcalls, the parameter order inCOBALT_parameter_doc.*has been slightly modified. Importantly, the parameter values remain consistent and unchanged.