Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added V3 version MOM_generic_tracer.F90 #108

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

yichengt900
Copy link
Collaborator

@yichengt900 yichengt900 commented Jan 2, 2025

As discussed, we are relocating MOM_generic_tracer.F90 (the BGC driver) from MOM6 to COBALT to provide greater flexibility for future development. This PR does not modify any baselines and will function correctly once this CEFI MOM6 PR is merged. This PR is nearly identical to #107, with a minor cleanup of MOM_generic_tracer.F90 to ensure it passes the MOM6 format check, in case we decide to replace the old version of MOM_generic_tracer.F90 in the current GFDL MOM6 repository. This PR must be tested with the latest dev/cefi MOM6 update.

@theresa-cordero
Copy link
Contributor

@yichengt900
This looks fine to me. Since we are changing every line in the file, could we also correct the indenting? nearly every line after ~16 is indented two extra spaces. It's a minor thing, but since we are changing the blame on all the lines anyway it seems like a good time to do this clean up step.

@yichengt900
Copy link
Collaborator Author

@theresa-morrison, thank you for the suggestion! I’ve updated the indenting accordingly.

@yichengt900 yichengt900 merged commit 154cd59 into dev/cefi Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants