added felim to diazo iron limitation #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @charliestock. It looks good to me. As you pointed out, the effect of this change is probably small and was not even caught by our 1D test case (which makes sense because our 1D test case is located in the middle of the ocean). I will approve it for now and will merge this PR once it has passed the NWA12 RT test. |
yichengt900
approved these changes
Apr 4, 2024
This was referenced Apr 4, 2024
Closed
|
Ok it also passed the NWA12 RT test at the CEFI-regional-mom6 side. Will merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updated the diazotroph iron limitation to be consistent with a change in the iron limitation calculation made for the other phytoplankton types in COBALTv3.0. The level of iron limitation is now calculated as the maximum of the limitations imposed by the internal cell quota (def_fe) and the ambient iron uptake limitation (felim).
While this fix changes answers, the effect is very small. It mainly removes small regions near river mouth where iron ends up being the most limiting nutrient simply because it takes a short time for high internal iron quotas to be established in high iron environments. Using the maximum of def_fe and felim removes this delay and puts iron on equal footing with N and P.
This adjustment also only effects the diazotrophs, which are generally a small fraction of the phytoplankton community.