-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observation window to Argo float obs and other BUFR-sourced obs #1423
Conversation
Automated GW-GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AndrewEichmann-NOAA . I'm not sure if that chunk of code is tested in the ci. We've got Argo in the obs list but I don't know if we have the Argo bufr in the 6 hrly dumps for March.
Still, looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- and @guillaumevernieres There are ARGO burf files in March 2021 except on 03/19/2021
, for file existence, see the /scratch1/NCEPDEV/da/Mindo.Choi/sandbox/file_check/gdas/2021/results_specific_03.out
.
@danholdaway @DavidHuber-NOAA Could one of you set off the CI? |
@AndrewEichmann-NOAA Do you need the GW CI tests launched? If so, can you point me to the GW PR to run them on? If you want the GDASApp CI tests launched, then someone else will need to do that as I don't have permissions (or know-how) to add the labels. |
Automated GW-GDASApp Testing Results:
|
@DavidHuber-NOAA i think the GDASApp CI will suffice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AndrewEichmann-NOAA
Description
Adds observation window to Argo float obs (4 cycles back and forward) and same facility for other BUFR-sourced obs. Since current BUFR to IODA converters handle one input file at a time, this is the interface this PR assumes, and so puts multiple argo IODA files, one per cycle, in the
obs
directory underCOM
.Tested with argo
Companion PRs
NA
Issues
Partially addresses #1132
Automated CI tests to run in Global Workflow