Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observation window to Argo float obs and other BUFR-sourced obs #1423

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

AndrewEichmann-NOAA
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Dec 19, 2024

Description

Adds observation window to Argo float obs (4 cycles back and forward) and same facility for other BUFR-sourced obs. Since current BUFR to IODA converters handle one input file at a time, this is the interface this PR assumes, and so puts multiple argo IODA files, one per cycle, in the obs directory under COM.

Tested with argo

Companion PRs

NA

Issues

Partially addresses #1132

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@guillaumevernieres guillaumevernieres self-assigned this Dec 19, 2024
@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Dec 19, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 19, 2024
@emcbot
Copy link

emcbot commented Dec 19, 2024

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Thu Dec 19 22:21:06 UTC 2024 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Dec 19 23:07:24 UTC 2024
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Dec 19 23:50:03 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 41

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 19, 2024
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewEichmann-NOAA . I'm not sure if that chunk of code is tested in the ci. We've got Argo in the obs list but I don't know if we have the Argo bufr in the 6 hrly dumps for March.
Still, looks good.

Copy link
Collaborator

@apchoiCMD apchoiCMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good- and @guillaumevernieres There are ARGO burf files in March 2021 except on 03/19/2021, for file existence, see the /scratch1/NCEPDEV/da/Mindo.Choi/sandbox/file_check/gdas/2021/results_specific_03.out .

@AndrewEichmann-NOAA
Copy link
Collaborator Author

@danholdaway @DavidHuber-NOAA Could one of you set off the CI?

@DavidHuber-NOAA
Copy link
Contributor

@AndrewEichmann-NOAA Do you need the GW CI tests launched? If so, can you point me to the GW PR to run them on? If you want the GDASApp CI tests launched, then someone else will need to do that as I don't have permissions (or know-how) to add the labels.

@RussTreadon-NOAA RussTreadon-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Dec 20, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 20, 2024
@emcbot
Copy link

emcbot commented Dec 20, 2024

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Fri Dec 20 15:52:42 UTC 2024 on hfe09
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Dec 20 16:41:08 UTC 2024
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Fri Dec 20 17:03:53 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 41

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 20, 2024
@AndrewEichmann-NOAA
Copy link
Collaborator Author

@DavidHuber-NOAA i think the GDASApp CI will suffice

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumevernieres guillaumevernieres merged commit a36255a into develop Jan 6, 2025
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/argo-window branch January 6, 2025 15:32
@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT Queue for automated testing with global-workflow on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants