Bugfix for ensemble update: rollback changes in gdas_ens_handler #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlyaeva
requested review from
RussTreadon-NOAA,
AndrewEichmann-NOAA and
apchoiCMD
apchoiCMD
approved these changes
Dec 31, 2024
guillaumevernieres
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix for #1429.
I am rolling back the change in
gdas_ens_handlerfrom #1417 that resulted in ensemble increments missing ssh which is used (at least to check dimensions) in mom6 IAU. From looking at the original PR I don't think this change was intentional, and I think it's OK to roll it back, although it would be good if someone with the knowledge of this workflow can review.Issues
Fixes #1429