-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code changes for the implementation of the low-resolution B #1441
Conversation
Automated GW-GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test, but I reviewed all the code changes, they look good to me.
Automated GW-GDASApp Testing Results:
|
Automated GW-GDASApp Testing Results:
|
Automated GW-GDASApp Testing Results:
|
Weird, it looks like it used the wrong commit of the g-w branch. I merged develop before resubmitting the ci but that;s not what was cloned here: /work2/noaa/da/role-da/CI/hercules/GDASApp/workflow/PR/1441/global-workflow |
Automated GW-GDASApp Testing Results:
|
Automated GW-GDASApp Testing Results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GDASApp ctests including C48mx500_3DVarAOWCDA and C48mx500_hybAOWCDA pass on Hera, Hercules, and Orion.
Approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
Here are the changes that I needed to do for the recenter task to succeed with a zero exit status: diff --git a/parm/soca/berror/soca_ensrecenter.yaml b/parm/soca/berror/soca_ensrecenter.yaml
index b700601..b7d8e20 100644
--- a/parm/soca/berror/soca_ensrecenter.yaml
+++ b/parm/soca/berror/soca_ensrecenter.yaml
@@ -60,5 +60,5 @@ output increment:
date: '{{ MARINE_WINDOW_END_ISO }}'
exp: trash
type: incr
- output file: 'ocn.recenter.incr.%mem%.nc'
+ output file: 'recenter.incr.%mem%.nc'
pattern: '%mem%' and diff --git a/utils/soca/gdas_ens_handler.h b/utils/soca/gdas_ens_handler.h
index 741055c..dd5fe9c 100644
--- a/utils/soca/gdas_ens_handler.h
+++ b/utils/soca/gdas_ens_handler.h
@@ -169,7 +171,30 @@ namespace gdasapp {
postProcIncr.setToZero(incr);
// Save the increments used to initialize the ensemble forecast
- result = postProcIncr.save(mom6_incr, i+1);
+ result = postProcIncr.save(mom6_incr, i+1, {"ocn"}); It fixes two issues: missing ice file (that we don't use in this usecase anyway) and wrong ocean file name. |
As the title says.
Dependencies
Work done in this PR
Interp to low-resolution:
Testing
Visual check showing the variance explained by the steric height (30 members)
![steic-explained-variance](https://private-user-images.githubusercontent.com/14031856/402715072-274c3fdb-94c3-42fc-ad6e-90867b39a778.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwODA0MjIsIm5iZiI6MTczOTA4MDEyMiwicGF0aCI6Ii8xNDAzMTg1Ni80MDI3MTUwNzItMjc0YzNmZGItOTRjMy00MmZjLWFkNmUtOTA4NjdiMzlhNzc4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDA1NDg0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0NDczMTk5YTM4MzgxMDA4OTUzNjRmMjM0MDg5ZTE0OTAxOGIxNTViMDE1M2QyNjY0NGZlYjVjYTU3OWMzMmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.CmwI08mHW1eXxWZtnQLcFZWNNMO7OB8FHyfcXlSIv4o)
left is native resolution, right is on the 1/2 deg grid.
"Science" note: The explained variance above is almost the opposite to what I would have expected, and what we saw in the previous offline ensemble, or even what we see in tendencies. Check if there's a bug in the explained variance calculation.
Automated CI tests to run in Global Workflow