[production/RRFS.v1] a new parameter to fix REFS member crash and new ccpp suites for RRFS fire weather #864
+177
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or not; new ccpp suites are added to support RRFS fire weather prediction
|
@JiliDong-NOAA is this fv3atm change ready to merge? |
|
@MatthewPyle-NOAA I think so. .gitmodules has been reverted with submodule updated. |
grantfirl
pushed a commit
to grantfirl/fv3atm
that referenced
this pull request
Dec 5, 2024
… ccpp suites for RRFS fire weather (NOAA-EMC#864) * a new parameter is added to control whether G-F will be cold started or not; new ccpp suites are added to support RRFS fire weather prediction
3 tasks
jkbk2004
pushed a commit
that referenced
this pull request
Jan 17, 2025
* [production/RRFS.v1] a new parameter to fix REFS member crash and new ccpp suites for RRFS fire weather (#864) * a new parameter is added to control whether G-F will be cold started or not; new ccpp suites are added to support RRFS fire weather prediction * fix RRFS_sas_nogwd suite name inconsistency (#868) * Add is_init flag for GFS_phys_time_vary to ccpp/data/GFS_typedefs.{F90,meta} and fix bug for Thompson MP init flag (used uninitialized, correct by coincidence) * update suites with GFS_photochemistry --------- Co-authored-by: Jili Dong <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After RRFS cycled DA switched to using saSAS, REFS members using G-F convection failed due to missing restarting variables. This PR will add a new parameter to control whether G-F will be cold started or not. The parameter will be set to false by default and won't affect any existing code logic/structure.
New ccpp suites are added to support RRFS fire weather
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
ufs-community/ccpp-physics#221
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
Requirements before merging