Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds logic to fix a problem in the _long cycles with the updated post script #605

Merged

Conversation

MatthewPyle-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • Introduces an alternate definition for the tm15, tm30, and tm45 subhourly files. These are used if they are found, and the main definition is not found.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A: - tested as a local change to the v1.0.0 system on dogwood. An hourly post job that had failed due to timing out completed normally with this change.
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic will likely need to be updated again in the future when the workflow is updated to use the umbrella data structure (those rrfs_post_${envir}_${cyc} directories will no longer exist). Thanks for getting it working in the current version.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 17761da into NOAA-EMC:main Jan 27, 2025
2 checks passed
@MatthewPyle-NOAA MatthewPyle-NOAA deleted the feature/15minlongfix branch January 27, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants