-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(devcontainer.json): add packages required for R tests #734
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard would it be to add a GitHub action that reminds us this container should be updated every time the DESCRIPTION file is updated?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #734 +/- ##
==========================================
- Coverage 68.71% 66.14% -2.57%
==========================================
Files 44 44
Lines 4714 4673 -41
Branches 197 0 -197
==========================================
- Hits 3239 3091 -148
- Misses 1428 1582 +154
+ Partials 47 0 -47 ☔ View full report in Codecov by Sentry. |
d255ea1
to
d6da39c
Compare
@kellijohnson-NOAA One option that might be of interest is the |
@kellijohnson-NOAA, @MOshima-PIFSC's suggestion sounds promising! I’ve copied the conversation over to Discussions so it doesn’t get lost in the PR. |
What is the feature?
How have you implemented the solution?
.devcontainer/devcontainer.json
Does the PR impact any other area of the project, maybe another repo?