-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up diag_table files to provide a default CEFI diag_table #108
Conversation
(1) What do you think about keeping the ocean, sea ice, and BGC diag tables as separate files? That way, for example, physics-only models could drop the BGC diags, and domains like the Pacific Islands could drop the sea ice diags. (2) This could be a good opportunity to consolidate the different file names within the BGC diag table. Particularly, ocean_cobalt_sfc, ocean_cobalt_omip_sfc, ocean_cobalt_omip_2d should be able to be consolidated into just ocean_cobalt_sfc (with some of the non-surface diags in ocean_cobalt_omip_2d going elsewhere). I think they're separate in part because OMIP wanted certain things in certain ways, but that shouldn't matter for us. |
@andrew-c-ross , thanks for your initial comments.
|
Hi @yichengt900, @andrew-c-ross, Thanks for pushing this forward. I agree with the logic on Andrew's first point. I think "CEFI_MOM6_default", "CEFI_SIS_default", and "CEFI_COBALT_default" would be fine. These could then be modified - hopefully gently - by region and product by the regional ocean modeling teams (i.e., CEFI_MOM6_NWA_Hindcast). Let's think on Andrew's second point a bit more. I don't like carrying around the extra stuff, but consistency with OMIP does help in some cases. The broader user community, for example, has set up scripts expecting CMIP names and units. The challenge is that these CMIP variables don't cover everything we need and aren't always the most natural breakdowns of the BGC. We may want to ultimately work on an efficient OMIP/CMIP add on to catch a few important fields. Let's have a first look at the breakdown according to Andrew's suggestion #1 and build from there. best, |
Thanks, @charliestock. Based on the conversation, I’ve split the |
@charliestock and @andrew-c-ross, I yhink this PR is ready to go. The configurations for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yichengt900. Thank you for putting the defaults together. I agree that these look good and are clearly moving us in the right direction on the diagnostic front. Please forge ahead with accepting these as the initial defaults and we can work to refine further in the coming months.
Hi YC, Andrew - yes, please move ahead with establishing these defaults and we can build from there. Thanks! |
We’re working to provide a CEFI
diag_table
that will offer the CEFI community a standardized set of default model outputs. I've consolidated the threediag_table
files we use for NWA12 (diag_table_MOM6_2024-04
,diag_table_COBALT_2024-04
, anddiag_table.SIS
), removing unused and unregistered variables, along with some COBALT OMIP and budget-check outputs.The size of this "default" output is 153 GB for NWA12 one year simulation. Please feel free to review and share any comments or suggestions you might have.