Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style update #1642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

thomas-robinson
Copy link
Member

Description
This is a code style update to reflect using the fms_ prefix for modules and routines that are public.

Fixes # (issue)

How Has This Been Tested?
Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@@ -89,7 +94,7 @@
same include subdirectory as the .fh files. See below for details.
## Fortran Example

```Fortran ./example.F90 file
```Fortran ./fms_public_example_example.F90 file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of public here and in the sample code below isn't what's captured in lines 13-15 above where it simply says fms_subfolder_. The inclusion of public implies we want everything to have public included in the naming scheme. I'd also recommend not have the double example called out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants