Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diss est fix #295

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Diss est fix #295

merged 2 commits into from
Oct 13, 2023

Conversation

JosephMouallem
Copy link
Contributor

Description

This MR fixes two issues with dissipation heating that arise in the following cases:
1- diss_est in the whole domain when do_vort_damp=.F.: damp_v will not allow a correct computation of local arrays ut, vt computed by del6_vt_flux and needed for the calculation of diss_est
2- diss_est in the sponge layers when do_vort_damp=.T.: d_con_k=0 in the sponge layers (set just before calling d_sw for k=1,2,3), this will not allow a correct computation of ub, vb since there is one condition (d_con > 1.e-5). ub, vb are used later to compute diss_est

This code change will fix ub, vb, ut, vt needed for the calculation of dissipative heating diss_est

Fixes #294

How Has This Been Tested?

Idealized tests on Gaea

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@laurenchilutti
Copy link
Contributor

I haven't reviewed the code changes, but I do want to point out that it seems the CI checks are failing due to Parallelworks Cloud cluster issues. I am hoping to restart the cluster and that the CI will begin to run again.

@laurenchilutti laurenchilutti merged commit 9af882c into NOAA-GFDL:main Oct 13, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong diss_est fields
4 participants