Update for AM5: turns off saturation adjustment in 2dz filter #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn off saturation adjustment in the 2dz filter for non-SHiELD configuration. See merge request fv3team/atmos_cubed_sphere!136
laurenchilutti
changed the title
|
@bensonr I am bringing this into the main branch via a PR so that CI can run on the commit before merging. This will then be cherry-picked to dev/gfdl_am5. |
bensonr
approved these changes
Oct 20, 2023
|
@laurenchilutti - do you need to cherry pick or can you simply merge Main into dev/gfdl_am5? |
|
I can compare what will happen with a merge of main to dev/gfdl_am5 versus the cherry-pick approach that I had been planning. A merge would be much simpler. |
|
Just tested and I will be able to just merge main to dev/gfdl_am5. Would you rather I do this vi a PR or would a manual merge be appropriate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings update from internal development branch to GitHub main branch (to bring to dev/gfdl_am5).
Turns off saturation adjustment in the 2dz filter for non-SHiELD configuration.
This will change answers for runs using fv_sg_adj > 0 in AM5.
Fixes # (issue)
How Has This Been Tested?
Tested by CI and by Linjiong.
Checklist:
Please check all whether they apply or not