-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
202411 Release of FV3 Dynamical Core #364
base: main
Are you sure you want to change the base?
Conversation
@@ -1,11 +1,82 @@ | |||
# RELEASE NOTES for FV3 202411: Summary | |||
FV3-202411-public --- November 2024 | |||
Lucas Harris, GFDL [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can credit this to a number of other folks not just myself, unless I am intended to be the primary scientific point of contact. In that case we should also list a technical PoC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can be more specific. Who would be the techincal Point of Contact? Maybe this could say
Scientific Point of Contact: Lucas Harris, GFDL [email protected]
Technical Point of Contact: <name>, GFDL <email>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The technical PoC could be either yourself or @JosephMouallem, or both. For SHiELD, the scientific PoC would be @linjiongzhou .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linjiongzhou would also be the PoC for the GFDL Microphysics, which we should list in these release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you are still the technical PoC for the dynamical core, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should I remove you from the list of Points of Contact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and keep me as a PoC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Our names are already in each specific item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell all of our changes have made it into this release. This looks good to me; thank you for undertaking this major task.
@@ -638,11 +638,11 @@ subroutine atmosphere_dynamics ( Time, Surf_diff ) | |||
Atm(n)%omga, Atm(n)%ua, Atm(n)%va, Atm(n)%uc, & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a later release I need to re-write this subroutine call so only Atm
is passed and not every single one of its members.
- Removed unused Keihl et al. (1994) cloud water effective radius diagnosis | ||
- Driver update (Joseph): | ||
- Implemented a new atmosphere driver to run SHiELD and SHiEMOM with the full FMScoupler. | ||
- Updates to $2\deltaz$ filter (fv_sg) (Lucas, Linjiong): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be $2\delta z$
with a space between 'delta' and 'z', my mistake.
Description
This PR publishes the FV3 Dynamical Core 202411 release. This release coincides with the release of SHiELD_physics 202411.
The changes included in this PR are from the GFDL FV3 Team. Full description of changes can be seen in the RELEASE.md
PRs that are all related and should be merged with this one:
SHiELD_physics PR #58
SHiELD_build PR #50
Fixes # (issue)
How Has This Been Tested?
Tested on Gaea
Checklist:
Please check all whether they apply or not