Debugging checksum on full range of Kh_h and Kh_q #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
bug
marshallward
approved these changes
Feb 19, 2025
Expand range of halos for checksums for Kh_h, Kh_q, Ah_h and Ah_q to cover the full range of values that are actually used. This includes expanding the range of values where the viscosities are calculated to those used in symmetric memory mode when DEBUG is true, even though these are not used for efficiency. One set of vorticity-point loop ranges was also corrected when the recently added parameter EY24_EBT_BS is true to avoid setting an extra unused value, perhaps correcting non-symmetric memory mode cases that would not reproduce across PE count and layout. All answers are bitwise identical in any case that reproduces across PE count.
Hallberg-NOAA
force-pushed
the
full_range_Kh_h_checksum
branch
from
2af4d32 to
7ab2c3d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #822 +/- ##
=============================================
- Coverage 38.10% 21.70% -16.41%
=============================================
Files 298 137 -161
Lines 87644 33184 -54460
Branches 16418 5944 -10474
=============================================
- Hits 33400 7203 -26197
+ Misses 48226 25425 -22801
+ Partials 6018 556 -5462 ☔ View full report in Codecov by Sentry. |
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26442. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand range of halos for checksums for
Kh_h,Kh_q,Ah_handAh_qto cover the full range of values that are actually used. This includes expanding the range of values where the viscosities are calculated to those used in symmetric memory mode when DEBUG is true, even though these are not used for efficiency. One set of vorticity-point loop ranges was also corrected when the recently added parameterEY24_EBT_BSis true to avoid setting an extra unused value, perhaps correcting non-symmetric memory mode cases that would not reproduce across PE count and layout. All answers are bitwise identical in any case that reproduces across PE count.