Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fre/cmor/README.md #135

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Create fre/cmor/README.md #135

merged 2 commits into from
Aug 14, 2024

Conversation

ilaflott
Copy link
Member

Describe your changes

adds back in old notes from original author's usage into cmor specific README.

no functionality changes. pipelines will be cancelled.

adds back in old notes from original author's usage into `cmor` specific README
@ceblanton
Copy link
Collaborator

I'm not sure these old notes are helpful... @Ciheim what do you think? We need some fresh cmor usage docs anyway

@ceblanton
Copy link
Collaborator

On second thought, if those examples were rephrased in fre-cli syntax (fre cmor run blah blah) and showed how to get the input files (instead of assuming they are there), it would be very useful.

@ilaflott
Copy link
Member Author

> On second thought, if those examples were rephrased in fre-cli syntax (fre cmor run blah blah) and showed how to get the input files (instead of assuming they are there), it would be very useful.

this is sort of what i was thinking. Also- i had actually meant to put these notes in fre cmor's README in the first place, when i was doing some clean up items suggested by pylint.

@ceblanton
Copy link
Collaborator

@Ciheim, after you return let's clean up Sergey's old usage examples with the new syntax, and explain how to get the input config files.

@ilaflott ilaflott marked this pull request as draft July 31, 2024 16:49
@ilaflott ilaflott marked this pull request as ready for review August 12, 2024 13:46
@ilaflott
Copy link
Member Author

let's just get this in, and start up a new PR/branch with CMOR doc edits to this README nugget

@ilaflott
Copy link
Member Author

ready to go

Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the usage syntax needs to be updated but otherwise it's useful

@ceblanton ceblanton merged commit a5e3377 into main Aug 14, 2024
3 checks passed
@ceblanton ceblanton deleted the ilaflott-patch-1 branch August 14, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants