Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pylint output more easily accessible in CI/CD #138

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

ilaflott
Copy link
Member

Describe your changes

this runs pylint as part of the conda env create check, in a separate workflow from conda build routines. it lets the pylint feedback be accessed with a single click- see checks on this PR!

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
    - [ ] I tried to comment my code
    - [ ] I wrote a new test, if applicable
    - [ ] I wrote new instructions/documentation, if applicable
    - [ ] I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

i want to see if i can get pylint to run as a sep step.

update workflow calls to reflect whats in the `conda build` target `meta.yml`
pylint feedback
@ilaflott ilaflott requested a review from ceblanton July 30, 2024 16:07
Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ceblanton ceblanton merged commit 1465431 into main Jul 30, 2024
3 checks passed
@ceblanton ceblanton deleted the CI.CD.experiment branch July 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants