Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intakebuilder --> catalogbuilder edits #140

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Conversation

ilaflott
Copy link
Member

Describe your changes

from scripts import gen_intake_gfdl and similar lines from the old noaa-gfdl::intakebuilder. now called noaa-gfdl::catalogbuilder. corresponding edits in meta.yaml, setup.py and environment.yml included. new import test line added to meta.yaml to check import

Issue ticket number and link (if applicable)

#128

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
    - [ ] I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

intakebuilder --> catalogbuilder
add catalogbuilder req
intakebuilder --> catalogbuilder edits. 


also delete some no-longer relevant commented out code, add doc string to click group entry point
@ilaflott ilaflott added the bug Something isn't working label Jul 30, 2024
@ilaflott
Copy link
Member Author

let me write a real pytest...

simple import test added outside of `conda build` routine
@ilaflott
Copy link
Member Author

ready-to-go, i recommend immediate merge, so the branch at #137 pipeline can merge the changes, and run the pipeline successfully

Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much more consistent. thank you!

@ceblanton ceblanton merged commit 8e085a1 into main Jul 30, 2024
3 checks passed
@ceblanton ceblanton deleted the 128.and_other_small_things branch July 30, 2024 18:47
@ilaflott ilaflott linked an issue Aug 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intakebuilder --> catalogbuilder
2 participants