These tests should NOT fail #151
Conversation
subtoolCli --> subtool_cli remove unnecessary pass and add docstrings
put back in sys import for yamltools
|
pylint score in current quick summary of changes:
|
more snake case enforcement. variables appearing unused to pylint b.c. of click conventions ignored in more places some unnecessary returns/passes/if-else conditions removed/rewritten a doc string here and there
…nment and github's CI/CD suspecting import problems with __init__.py file in fre/app/. everything works fine locally. committing + pushing this while clobbering local folder/caches to start from a cleaner spot
adding back in...
used https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions as reference also fix pylint warning about freyamltools.py and freyamltoolsexample.py in fre/yamltools
…fre-cli into this_test_should_fail
…bility add some extra echo / which output to see if i understand the gh CICD env
|
this PR now contains autogenerated documentation from python doc-strings! |
|
ready to go |
last tweak- couldnt look at the long-line admonishments anymore
| print(f"Processed {var}") | ||
|
|
||
| return masked | ||
|
|
||
|
|
||
| def pressure_coordinate(ds, varname, verbose=False): | ||
| def pressure_coordinate(ds, varname):#, verbose=False): |
There was a problem hiding this comment.
verbose wasn't used, I see
There was a problem hiding this comment.
true! commented out... since it's not a BAD idea
| import click | ||
| import catalogbuilder | ||
| #import catalogbuilder |
There was a problem hiding this comment.
it is not! if it were, the new API tests in fre/catalog/tests would be failing
There was a problem hiding this comment.
I can't disagree with you. But it's weird still isn't it? should we remove the line then?
| """ - Generate .csv and .json files for catalog """ | ||
| context.forward(gen_intake_gfdl.main) | ||
| context.forward(gen_intake_gfdl.create_catalog_cli) |
There was a problem hiding this comment.
Describe your changes
split up cli tests, add a new one based on the
catalogbuilderinterface, so we'll know if it changes again via a failed test.Issue ticket number and link (if applicable)
#149
Checklist before requesting a review
N/A
- [x] I wrote new instructions/documentation, if applicable