-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding reduced ascii file + updating pytest to convert it to binary #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I didn't give it a try yet, but doesn't the .cdl file need some data points on the reduced grid?
fre/tests/test_files/reduced_ascii_files/reduced_ocean_monthly_1x1deg.199301-199712.sos.cdl
Outdated
Show resolved
Hide resolved
Looking good- can you |
Is this ready? The tests may not be passing, but maybe it just needs a re-try. |
|
fre/tests/test_files/reduced_ascii_files/reduced_ocean_monthly_1x1deg.199301-199712.sos.cdl
Outdated
Show resolved
Hide resolved
Merging main into branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made needed changes
the checks fail in |
i'm certain @ceblanton would approve this. We're all running around like chickens with no heads at the moment!!! the code follows the current pattern. the test works. even generalizing to other tests should be clear enough!
Describe your changes
Issue ticket number and link (if applicable)
Checklist before requesting a review