Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/update netcdf version for docker files #102

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Hotfix/update netcdf version for docker files #102

merged 4 commits into from
Jan 27, 2025

Conversation

oelbert
Copy link
Contributor

@oelbert oelbert commented Jan 22, 2025 •
edited
Loading

Description
Updates the netcdf4 python version to 1.7.1 which fixes path errors that prevented the docker images from building successfully

How Has This Been Tested?
Docker images have been successfully rebuilt after this update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

fmalatino
fmalatino previously approved these changes Jan 22, 2025
View reviewed changes
@oelbert
Copy link
Contributor Author

oelbert commented Jan 22, 2025

This PR and NDSL PR NOAA-GFDL/NDSL#100 both depend on each other to pass...

@oelbert oelbert mentioned this pull request Jan 22, 2025
Merged
7 tasks
@oelbert oelbert requested a review from fmalatino January 27, 2025 19:57
fmalatino
fmalatino approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@fmalatino fmalatino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 5092938 into NOAA-GFDL:develop Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmalatino fmalatino fmalatino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oelbert @fmalatino