Jbacon ims latlong #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuLieAlgebra
force-pushed
the
jbacon_ims_latlong
branch
from
0f2f3b4
to
f78c34a
Compare
Delete icedyno/preprocess/preprocess_netcdf.ipynb Incorrect formatting Add files via upload Delete icedyno/preprocess/preprocess_netcdf.ipynb Improper formatting Add files via upload
…ordinates from x,y values and equations
…st, more to come. Had to include init for tests to see the icedyno project to import
cropped pipeline: Parallelized workflow to crop original IMS netcdf files to centered window at variable window size with luigi
…reprocess/geolocation. Returning x, y in meters and pinning constant values to IMS specific ones. Updated test to reflect change
…ten tests suggests.
…nted out print statements
JuLieAlgebra
force-pushed
the
jbacon_ims_latlong
branch
from
f78c34a
to
9e5147c
Compare
SooluThomas
reviewed
Mar 17, 2024
…ule, cleanup latlon notebook, addfind closest index in grid function to geolocation module.
…ion for lat/lon crop windows
It's cleaned up now! And ready for review |
… found by manual work in colab. Corrects out of memory error with netcdf rotations with temporary solution to an initial crop before grid correction.
…ression settings in original netcdf file
JuLieAlgebra
force-pushed
the
jbacon_ims_latlong
branch
from
9d8b147
to
66c6baf
Compare
JuLieAlgebra
commented
Mar 18, 2024
SooluThomas
reviewed
Mar 19, 2024
SooluThomas
reviewed
Mar 19, 2024
…ould look like with google maps, added descriptions
SooluThomas
approved these changes
Mar 19, 2024
mthanos7
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major features:
Details on Grid Rotation Solution
We can't rotate the entire netcdf image due to its size, but we also can't select the right window without correcting grid with a rotation first. Temporary solution is to crop to a large, but much smaller than original image first, then rotate and crop to correct window. Throws an assert error if the first crop excludes the selected window.
Details on lat/lon conversion:
Removed northern hemisphere considerations and removes a set of lines in the original
polar_xy_to_lonlatthat causes the longitude to become invalid (>180) for certain lonlat pairs.https://github.com/nsidc/polarstereo-lonlat-convert-py/blob/366069fc65e781c277adf6d2fb0dac60c521d77d/polar_convert/polar_convert.py#L60C1-L61C38
Previously, the tests I wrote to check that the conversions should undo each other doesn't pass with that re-wrapping of the longitude value. Now it does.
The original functions from latlon to xy actually don't have any tests: https://github.com/nsidc/polarstereo-lonlat-convert-py/blob/main/polar_convert/test.py