generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-cfe2.0_cleanup #121
Merged
Merged
pre-cfe2.0_cleanup #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajkhattak
force-pushed
the
ajk/pre-cfe2.0-cleanup
branch
from
June 25, 2024 19:19
c142ecd
to
2bc03a8
Compare
ajkhattak
force-pushed
the
ajk/pre-cfe2.0-cleanup
branch
from
July 2, 2024 19:37
bcc7669
to
a8cc575
Compare
…ace, and a few other minor changes.
…kip the iteration.
… Nash cascade surface.
…-optional params are missing.
…f_nash_surface for consistency.
…giuh_ordinate to zero to avoid garbage when runoff scheme is NASH_CASCADE.
ajkhattak
force-pushed
the
ajk/pre-cfe2.0-cleanup
branch
from
July 2, 2024 19:42
a8cc575
to
42dea3c
Compare
madMatchstick
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through the entire install.md
for good measure. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things have been cleaned up (moved/removed) before the cfe2.0 release. No changes to the code.
Additions
Removals
params
directory, which is neither needed nor directly related to cfe code.Changes
Testing
Checklist