Fixed issues with base flow and added the Xinanjiang routine #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Base flow was not generated correctly because soil and groundwater reservoir fluxes were not updated correctly. The current python version of CFE does not have the Xinanjiang routine and some of the variables in the newest C version of CFE. This pull request tries to fix the issue with base flow simulation and updates the python-version CFE to have identical functionalities as the newest C-version CFE.
Additions
added the Xinanjiang surface partitioning routine adapted from the C version of CFE
added a variable in the configuration files and
bmi_cfe.py
to define which surface partitioning routine to useChanges
primary_flux_m
andsecondary_flux_m
should be used to update percolation and lateral flux instead ofprimary_flux
andsecondary_flux
primary_flux_m
should be used to update the variableflux_from_deep_gw_to_chan_m
Testing
cat_58_config_cfe.json
)cat_58_config_cfe_x.json
)test_cfe_bmi.ipynb