Prob compare #169
Merged
Prob compare #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added probabilistic metrics via `compute_probabilistic_metrics.py` - added `probabilistic_compare()` as gval accessor method - added `_compare_metrics_df_with_xarray()` to compare df's with xarray objects - added probabilistic compare accessor method - added xskillscore as dependency - updated docstrings to represent correct module name or function - deprecated `load_raster_as_xarray()` #50 - added `_create_circle_mask()`, `_create_xarray()`, and `_create_xarray_pairs()` - added `Prob_metrics_df` dataframe schema
- updated tests to use `Prob_metrics_df` schema for `expected_df`s - stopped coercion for `Prob_metrics_df` schema - ran `black` and `flake8` - updated crps_ensemble test to use correct size variable
- updated `_assert_pairing_dict_equal()` to use `np.testing.assert_equal()` - addition of xskillscore slightly changed some values for continuous metrics. - fixed skipped test `test_create_xarray_pairs()`
- updated `_assert_pairing_dict_equal()` to use deepdiff
- added deepdiff as dev dependency
- updated values for continuous compare metrics
- most likely introduced due to dependency updates
- differences are very minor to 10+ decimal places
- ensured expected dict is PairingDict object
- updated `_assert_pairing_dict_equal()` docstring
GregoryPetrochenkov-NOAA
requested changes
Dec 14, 2023
tests/cases_load_xarray.py
Outdated
| (0, 1, (7, 7), 3), # band 2 | ||
| ] | ||
|
|
||
| data_band_1 = np.array( |
There was a problem hiding this comment.
This and data defined at line 47, 116, and 280 could be defined once somewhere in the script. Perhaps other variables could be not repeated as well.
There was a problem hiding this comment.
All repeated variables in this module were moved to global status. Changes in those values at the function level remain in place.
| sizes = (sizes, sizes) | ||
|
|
||
| # handle shapes | ||
| if shapes == "circle": |
There was a problem hiding this comment.
I would remove 318-325 and delegate check for valid shape to the loop starting 330 unless this is for memory purposes or some future masks may generalize to multiple shapes.
There was a problem hiding this comment.
Yes, the purpose of this is to support other array creation functions eventually.
| # background value, circle value, circle center, and circle radius | ||
| band_params_benchmark = [ | ||
| (145, 360, (25, 25), 15), | ||
| # (160, 360, (2, 2), 3), |
There was a problem hiding this comment.
Unless there is a purpose remove commented lines.
- moved function level variables to global where applicable in `cases_load_xarray.py` - updated comments for band level params to include (x, y) coords - removed legacy commented lines
GregoryPetrochenkov-NOAA
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probabilistic metrics
_assert_pairing_dict_equal()to usedeep diff.DeepDiff()functionProb_metrics_dfschema forexpected_dfsProb_metrics_dfschemablackandflake8compute_probabilistic_metrics.pyprobabilistic_compare()as gval accessor method_compare_metrics_df_with_xarray()to compare df's with xarray objectsload_raster_as_xarray(). closes Deprecate_load_xarray()and_load_raster_as_xarray()#50_create_circle_mask(),_create_xarray(), and_create_xarray_pairs()Prob_metrics_dfdataframe schema