refactor: better handling of plugin types for ModelHook manager

NOAA-OWP · Jul 25, 2024 · d8c66e8 · d8c66e8
1 parent 4f4c740
commit d8c66e8
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/python/ngen_cal/src/ngen/cal/_plugin_system.py b/python/ngen_cal/src/ngen/cal/_plugin_system.py
@@ -28,15 +28,14 @@ def setup_plugin_manager(plugins: list[Callable | ModuleType]) -> PluginManager:
 
     return pm
 
-def setup_scoped_plugin_manager(spec: type, plugins: list[Callable | ModuleType]) -> PluginManager:
+def setup_scoped_plugin_manager(spec: type, plugins: list[Callable]) -> PluginManager:
     pm = pluggy.PluginManager(PROJECT_SLUG)
     pm.add_hookspecs(spec)
 
     for plugin in plugins:
+        assert not isinstance(plugin, ModuleType), "function plugins"
         if isinstance(plugin, Callable):
             pm.register(plugin())
-        elif isinstance(plugin, ModuleType):
-            pm.register(plugin)
         else:
             assert_never(plugin)