Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow netcdf forcing #142

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 31, 2024

closes #134

Add support for forcing files without patterns (e.g. netcdf).

@aaraney aaraney marked this pull request as ready for review August 13, 2024 00:15
@aaraney aaraney requested a review from hellkite500 August 13, 2024 00:15
@aaraney aaraney added enhancement New feature or request ngen.cal Related to ngen.cal package labels Aug 13, 2024
@aaraney aaraney self-assigned this Aug 13, 2024
@hellkite500
Copy link
Contributor

Did you happen to run a test of this with a netcdf realization and forcing file? I had suspected (and I'm still not 💯 convinced) that some additional changes would be needed to handle NetCDFProvider in config. A quick look though implies that maybe that has been supported in the config generation/validation for a while? Maybe this was a lot simpler than I had originally thought 🥳

@aaraney
Copy link
Member Author

aaraney commented Aug 14, 2024

I had @ajkhattak run a test to verify that it worked. Still need to test it out for myself.

Aside, I would really like to prioritize getting integration tests setup in CI so this could just become a test case.

@ajkhattak
Copy link

I think I can run a quick test to check if it works with both .nc and .csv formats, if that would help.

@aaraney
Copy link
Member Author

aaraney commented Aug 14, 2024

@ajkhattak, yeah that would be great. Thanks for offering!

@aaraney
Copy link
Member Author

aaraney commented Aug 14, 2024

@ajkhattak, tested and was able to run the model

@hellkite500 hellkite500 merged commit 0bdb4e0 into NOAA-OWP:master Aug 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ngen.cal Related to ngen.cal package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ngen realizations with NetCDF data providers for forcing
3 participants