Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop uses_forcing_file field #144

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 31, 2024

NextGen dropped support for uses_forcing_file in NOAA-OWP/ngen#826. This PR drops support for uses_forcing_file in ngen.config.

ngen.config -- 0.3.0

Removals

@aaraney aaraney added ngen.config Related to ngen.config package enhancement New feature or request labels Jul 31, 2024
@aaraney aaraney marked this pull request as ready for review July 31, 2024 20:39
@aaraney
Copy link
Member Author

aaraney commented Jul 31, 2024

@robertbartel, I did a github search of the noaa-owp and CIROH orgs looking for any usage of uses_forcing_file and came up empty. Can you double check me just to be on the safe side?

@aaraney aaraney merged commit 0c9e843 into NOAA-OWP:master Aug 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ngen.config Related to ngen.config package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove uses_forcing_file and forcing_file options
2 participants