Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(py3.12): explicitly call __init__ to setup PurePath instance #195

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix(py3.12): explicitly call __init__ to setup PurePath instance #195

merged 2 commits into from
Sep 25, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Sep 10, 2024

Fixes #193.

See #193 for detail.

@aaraney aaraney added bug Something isn't working ngen.config Related to ngen.config package labels Sep 10, 2024
@aaraney aaraney requested a review from hellkite500 September 10, 2024 19:13
@aaraney aaraney self-assigned this Sep 10, 2024
@aaraney
Copy link
Member Author

aaraney commented Sep 10, 2024

Once #187 is merged, this needs to be rebased off of master and re-pushed. This should fix the test failures.

@hellkite500 hellkite500 merged commit 2823b2c into NOAA-OWP:master Sep 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellkite500 hellkite500 hellkite500 approved these changes

Assignees

@aaraney aaraney

Labels
bug Something isn't working ngen.config Related to ngen.config package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PathPair is not printable in 3.12; Explicitly call __init__ after instance has been established
2 participants
@aaraney @hellkite500