Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lgar, sft, and smp modules #97

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Feb 26, 2024

Add nextgen realization models for LGAR, Soil Freeze Thaw, and Soil Moisture Profile modules.

ngen.config -- 0.2.6

Additions

  • Add nextgen realization models for LGAR, Soil Freeze Thaw, and Soil Moisture Profile modules.

@hellkite500
Copy link
Member

Add test cases, then we can merge.

@hellkite500
Copy link
Member

hellkite500 commented Mar 15, 2024

Can you add Xia as a coathor to this commit bc913a3 and rebase?

Can add in the commit message trailer.
Co-authored-by: Name

@aaraney
Copy link
Member Author

aaraney commented Mar 18, 2024

Can you add Xia as a coathor to this commit bc913a3 and rebase?

Can add in the commit message trailer. Co-authored-by: Name

Yep, done!

For those interested in doing this themselves, this was really helpful.

@aaraney
Copy link
Member Author

aaraney commented Mar 18, 2024

Add test cases, then we can merge.

Yep, done!

@hellkite500
Copy link
Member

Thinking about conventional commits, we should maybe adopt a version(major):, version(minor):, version(bug) convention, or some other set of version(context): prefixes to help parse history for version changes. We tend to use a lot of "bump" like commit messages as is, so having a defined set of tags to search for later might be nice.

@hellkite500 hellkite500 merged commit b024f3f into NOAA-OWP:master Mar 20, 2024
13 checks passed
@aaraney
Copy link
Member Author

aaraney commented Mar 20, 2024

We tend to use a lot of "bump" like commit messages as is, so having a defined set of tags to search for later might be nice.

@hellkite500, I think what you want is right under your nose! I would advise using git tags for versions instead of relying on commits. For namespace packages, I am a fan of {namespace}.{package}/vM.m.P. To you point, in the future I hope we can remove the need to bump package _version.py files and solely rely on git for package versions. See #92 for a draft proposal of this.

@hellkite500
Copy link
Member

hellkite500 commented Mar 20, 2024

Not sure you can ever get away from commits which change some text in the repo based on a version change. E.g change logs, release notes, ect. My previous comment was simply about a commit prefix that helps track down version info changes in the history using conventional commit strategies.

I agree git tags would be helpful, and a set of version commit prefixes may be prime candidates for which commits get tagged!

A git tag, after all, is still a commit...

@stcui007
Copy link
Contributor

stcui007 commented Mar 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants