Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoPackage divide_id attribute hotfix #625

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

mattw-nws
Copy link
Contributor

@mattw-nws mattw-nws commented Sep 1, 2023

HF pre-release files actually use a different schema and different ID attribute for divides, this PR makes that version work properly for GPKG files. The new format in geojson representation is not fixed. This may break older GPKG formats, but tries to leave them working--no guarantees. Going forward GPKG format is only intended to support the latest HF formats.

Additions

  • Can now pass an id_col when reading features table from GPKG, some probing tries to guess which to pass for the divides layer.

Removals

Changes

Testing

Screenshots

Notes

Todos

  • Probably remove support for the never-released format, do something with geojson support (update for new format/both formats, or deprecate?)

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@PhilMiller
Copy link
Contributor

Code otherwise looks reasonable to me.

@mattw-nws mattw-nws marked this pull request as ready for review September 6, 2023 18:25
src/geopackage/read.cpp Outdated Show resolved Hide resolved
hellkite500
hellkite500 previously approved these changes Sep 12, 2023
@mattw-nws
Copy link
Contributor Author

I finally validated that the updated sample dataset included here does work with routing, so this is ready to go. I noticed that I omitted some deletions however. @PhilMiller or @hellkite500 can you re-approve? Thanks.

@mattw-nws
Copy link
Contributor Author

Merging--failing test waiting on NOAA-OWP/t-route#645 .

@mattw-nws mattw-nws merged commit a8f3e93 into NOAA-OWP:master Sep 18, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants