generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoPackage divide_id
attribute hotfix
#625
Merged
mattw-nws
merged 5 commits into
NOAA-OWP:master
from
mattw-nws:gpkg-id-attribute-hotfix
Sep 18, 2023
Merged
GeoPackage divide_id
attribute hotfix
#625
mattw-nws
merged 5 commits into
NOAA-OWP:master
from
mattw-nws:gpkg-id-attribute-hotfix
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilMiller
reviewed
Sep 1, 2023
Code otherwise looks reasonable to me. |
hellkite500
reviewed
Sep 8, 2023
hellkite500
previously approved these changes
Sep 12, 2023
Co-authored-by: program-- <[email protected]>
Co-authored-by: Nels <[email protected]>
mattw-nws
force-pushed
the
gpkg-id-attribute-hotfix
branch
from
September 13, 2023 18:27
4ec960a
to
ded2b17
Compare
I finally validated that the updated sample dataset included here does work with routing, so this is ready to go. I noticed that I omitted some deletions however. @PhilMiller or @hellkite500 can you re-approve? Thanks. |
PhilMiller
approved these changes
Sep 14, 2023
Merging--failing test waiting on NOAA-OWP/t-route#645 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HF pre-release files actually use a different schema and different ID attribute for divides, this PR makes that version work properly for GPKG files. The new format in geojson representation is not fixed. This may break older GPKG formats, but tries to leave them working--no guarantees. Going forward GPKG format is only intended to support the latest HF formats.
Additions
id_col
when reading features table from GPKG, some probing tries to guess which to pass for the divides layer.Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support