Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move merged CONUS realization configs to data/baseline/realizations/ #884

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

stcui007
Copy link
Contributor

@stcui007 stcui007 commented Sep 26, 2024

This small PR moves some of the already merged realization configs for CONUS computation to a new directory so that all realization config files will be in one place.

Changes

Move realization config files from data/baseline to data/baseline/realizations

Testing

These files have previously been tested.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Copy link
Contributor

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked via git grep conus_bmi_multi master that there were no references to these files in their old paths. Thanks for consolidating this!

@PhilMiller PhilMiller merged commit f321889 into NOAA-OWP:master Sep 27, 2024
19 checks passed
@stcui007
Copy link
Contributor Author

Thanks for your review, Phil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants