Ngen fixes #592
Open
Ngen fixes #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hellkite500 Per discussion, I think this fixes one or more of #581 , #582 , and #583 ? Can you comment on which? |
hellkite500
force-pushed
the
ngen-fixes
branch
from
5cb622a to
f1b7a18
Compare
kumdonoaa
reviewed
Nov 9, 2022
| if qlat_values.shape[1] < nsteps: | ||
| raise ValueError(f"Number of columns (timesteps) in Qlat is incorrect: expected at most ({data_idx.shape[0]}), got ({qlat_values.shape[1]}). The number of columns in Qlat must be equal to or less than the number of routing timesteps") | ||
| if qlat_values.shape[1] < nsteps/qts_subdivisions: | ||
| raise ValueError(f"Number of columns (timesteps) in Qlat is incorrect: expected at least ({data_idx.shape[1]/(nsteps/qts_subdivisions)}), got ({qlat_values.shape[1]}). The number of columns in Qlat must be at least the number of routing timesteps") |
There was a problem hiding this comment.
qts_subdivisions in Line 225 should be equal to dt_qlat / dt, where dt_qlat and dt are lateral flow data time interval and channel routing time interval, respectively.
shorvath-noaa
approved these changes
Nov 14, 2022
groutr
reviewed
Dec 8, 2022
| #but it isn't clear right now how to do that with flow/velocity/depth requirements | ||
| #find the terminal nodes | ||
| for tnx, up in terminal_links.items(): | ||
| print(up, tnx) |
There was a problem hiding this comment.
Is this print supposed to be here?
There was a problem hiding this comment.
Only if you like non-contextual debugging information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes on hy_features network with relation to handling terminal links and qlateral flows, and (another) fix in the validation logic for the length of qlats. These changes were tested on the ngen branch and ported over here to keep these classes in sync as much as possible between the branches until we get a
mainon the master branch.Additions
Removals
Changes
Testing
Checklist
Target Environment support