-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create antismash downloader module and move there inherent code #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, see my comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! A few more comments, almost there :-)
add type hint Co-authored-by: Cunliang Geng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's almost there, 4 more comments to go
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
Co-authored-by: Cunliang Geng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort! PR approved 🎉
The test error you mentioned is fine, it's already fixed in dev
branch.
Please Squash and merge
the PR, then you can close it.
download_antismash_data
, which now is deprecated, and created a new onedownload_and_extract_antismash_data
, which takes as input a single item id to be used to retrieve Antismash data. In the refactored downloader for PoDP it will be inserted in a for loop to iterate over all the items available. The downloader module will be refactored in a different PR (see issue RefactorDownloader
class to have a specific PoDP downloader #121).test_antismash_downloader.py
andtest_antismash_loader.py
.One test is still failing: