add filter method to LinkGraph

[CunliangGeng]

To solve #265

[CunliangGeng]

• add filter method to LinkGraph #269 👈
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite

[gcroci2]

Thanks for having added the filter, very very useful :)

I think there is a bug in the code - see the comment.

Also, note that the filter gives different results compared to when I filter on the same objects as it follows:

gcfs_selected = gcfs[:5]
bgcs_selected = [bgc for gcf in gcfs_selected for bgc in gcf.bgcs]
mfs_selected = mfs[:5]
spectra_selected = [spec for mf in mfs_selected for spec in mf.spectra]

lg_selected = LinkGraph()
for gcf in gcfs_selected:
    for spec in spectra_selected:
        if links.has_link(gcf, spec):
            lg_selected.add_link(gcf, spec, **links.get_link_data(gcf, spec))
    for mf in mfs_selected:
        if links.has_link(gcf, mf):
            lg_selected.add_link(gcf, mf, **links.get_link_data(gcf, mf))

# lg_selected has 74 links

Compared to when I do this

lg_selected = links.filter(gcfs_selected, spectra_selected)
# lg_selected has 68 links

[CunliangGeng]

Try lg_selected = links.filter(gcfs_selected, spectra_selected + mfs_selected) which should give you 74 links. Don't forget the + mfs_selected

[gcroci2]

Try lg_selected = links.filter(gcfs_selected, spectra_selected + mfs_selected) which should give you 74 links. Don't forget the + mfs_selected

Indeed it works! :D

[CunliangGeng]

Merge activity

• Jul 15, 6:56 AM EDT: @CunliangGeng started a stack merge that includes this pull request via Graphite.
• Jul 15, 6:57 AM EDT: @CunliangGeng merged this pull request with Graphite.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud