Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputInitial DynamicsOutput #337

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Add OutputInitial DynamicsOutput #337

merged 2 commits into from
Apr 11, 2024

Conversation

Alexsp32
Copy link
Member

It's like OutputFinal, but for the start of a trajectory. #innovation

@Alexsp32 Alexsp32 requested a review from Nhertl April 11, 2024 08:54
@Alexsp32 Alexsp32 self-assigned this Apr 11, 2024
Copy link

@Nhertl Nhertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 😊

@Alexsp32 Alexsp32 merged commit 6abe12c into main Apr 11, 2024
9 of 10 checks passed
Alexsp32 added a commit that referenced this pull request Apr 15, 2024
* Add OutputInitial DynamicsOutput
reinimaurer1 added a commit that referenced this pull request Feb 21, 2025
…332)

* Add Simulation-aware VelocityBoltzmann with support for frozen atoms.

* Forgot to add new file

* Basic docs

* Forgot second arg in mobileatoms call

* Add OutputInitial DynamicsOutput (#337)

* Add OutputInitial DynamicsOutput

* Fix allocation-based unit tests (#336)

* Stopgap fix for failing unit tests based on memory allocation

* Add allocation test debug messages

* Fixed version logic to be defined for all Julia versions

* Analysis functions for diatomic molecules.  (#329)

- Added new DynamicsOutput: OutputDesorptionTrajectory #317
- Added new DynamicsOutput: OutputDesorptionAngle #317
- Created an `Analysis` submodule for common analysis functions

-  Add `Structure` submodule for common utility functions for atomic structure. 

* Add rudimentary tests for NQCDynamics.Structure

* Improved method definitions, possible efficiency gain by using views

* Add unit tests for diatomic analysis functions for desorption

* Add "Analysis" group to unit testing

* Added explanation for Structure module scope

* Add unit tests and fix a mistake

* Wrong path for test asset

* Add DynamicalDistribution constructor from Simulation, add test for correct atom freezing.

---------

Co-authored-by: Reinhard Maurer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants