-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phonon thermostat #349
Phonon thermostat #349
Conversation
OutputTemperature should hopefully not cause OOMs any more. OutputFirst changed to OutputInitial, fits better with OutputFinal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left lots of minor comments, mostly related to docs. There is one bit I don't quite understand, but we can discuss offline at some point.
Yes, however the Integrator chosen as part of the |
@reinimaurer1 ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes. all good
Phonon thermostatting in NQCD
Implements MDEF + 2TM with Phonon coupling (#73) by changing
Simulation
s to allow the use of different temperatures (either a constant value or function) for each atom by usingThermostat
s, which behave like aSubsystem
(see NQCD/NQCModels.jl#39), applying a temperature to parts of aSimulation
.Combine with NQCD/NQCModels.jl#39, which introduces
Subsystem
s, which apply aModel
exclusively to certain atoms in aSimulation
. These can be combined arbitrarily forModel
types implementingpotential
,derivative
orfriction
to generate a combined friction matrix for electronic and phononic friction.ToDo