Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed location of get_hopping_eigenvalues() to SurfaceHoppingMethods.jl #353

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

Ash-Baldwin
Copy link
Contributor

Moved the definitions of get_hopping_eigenvaues() to a more sensible location in SurfaceHoppingMethods()

changed the location of the definition of the get_hopping_eigenvalues() function to SurfaceHoppingMethods.jl so this general surface hopping function is defined in a more appropriate location
Previous commit copied over the wrong function from SurfaceHoppingMethods\rpsh.jl
Copy link
Member

@Alexsp32 Alexsp32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing CI test is due to #354 and unrelated to this PR.
IMHO more logical placement of these functions considering their use across different DynamicsMethods.

@Ash-Baldwin Ash-Baldwin merged commit 186c2d1 into main Oct 30, 2024
11 of 12 checks passed
@Ash-Baldwin Ash-Baldwin deleted the origin/Ash branch October 30, 2024 14:30
@Ash-Baldwin Ash-Baldwin restored the origin/Ash branch October 31, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants