Somehow parts of #359 went missing #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexsp32
changed the title
|
It might be my fault as I had to resolve some merge conflicts when I merged it with master
Prof. Dr. Reinhard Maurer
Department of Chemistry, University of Warwick
…________________________________
From: Alexander Spears ***@***.***>
Sent: Monday, March 3, 2025 1:45:24 PM
To: NQCD/NQCDynamics.jl ***@***.***>
Cc: Maurer, Reinhard ***@***.***>; Review requested ***@***.***>
Subject: [NQCD/NQCDynamics.jl] Somehow parts of #359 went missing (PR #371)
I don't know how these bits went missing, I swear the docs built properly for me Friday afternoon, but now they should build properly in CI again.
________________________________
You can view, comment on, or merge this pull request online at:
#371
Commit Summary
* 24bce58<24bce58> 💚 Somehow parts of #359 went missing
File Changes
(3 files<https://github.com/NQCD/NQCDynamics.jl/pull/371/files>)
* M docs/Project.toml<https://github.com/NQCD/NQCDynamics.jl/pull/371/files#diff-6e0adb5e01dce01db395f52201532ad8fec022922489f34827886053953ce93f> (1)
* M docs/make.jl<https://github.com/NQCD/NQCDynamics.jl/pull/371/files#diff-4aae2d1c783cade58bd2cb13748da956e568b7f2aed5fafd9e2a46fb97daf613> (2)
* M docs/references.bib<https://github.com/NQCD/NQCDynamics.jl/pull/371/files#diff-9e696d253e1559081cbc14060ab857b33b9c7847a6b6a572f1e473d479718500> (5)
Patch Links:
* https://github.com/NQCD/NQCDynamics.jl/pull/371.patch
* https://github.com/NQCD/NQCDynamics.jl/pull/371.diff
—
Reply to this email directly, view it on GitHub<#371>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACBN7WTZEKMXHXNN3NX45QL2SRMHJAVCNFSM6AAAAABYHB7F46VHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4TCMZQGE3DOMA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how these bits went missing, I swear the docs built properly for me Friday afternoon, but now they should build properly in CI again.