Merge pull request #221 from NRCHKB/dev

Version 1.0.4
NRCHKB · Mar 3, 2020 · ffb2289 · ffb2289
2 parents efb19d8 + 892c221
commit ffb2289
Show file tree

Hide file tree

Showing 4 changed files with 139 additions and 154 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.4] - 2020.03.03
+
+### Fixed
+-   Warn when trying to deploy node without bridge or parentService attached [#214](https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/214#issuecomment-594084125)
+-   Additional Command Line value in Camera Control is now optional [#214](https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/214#issuecomment-593736115)
+
 ## [1.0.3] - 2020.03.01
 
 ### Fixed

diff --git a/homekit.html b/homekit.html
@@ -205,7 +205,7 @@ <h3 id="toc_5">Service</h3>
               <li><strong>Map Video</strong>: Select the stream used for video, default <em>0:0</em>.</li>
               <li><strong>Map Audio</strong>: Select the stream used for audio, default <em>0:1</em>.</li>
               <li><strong>Video Filter</strong>: Allows a custom video filter to be passed to FFmpeg via -vf, defaults to <em>scale=1280:720</em> but is optional.</li>
-              <li><strong>Additional Command Line</strong>: Allows additional of extra command line options to FFmpeg, default <em>-tune zerolatency</em>.</li>
+              <li><strong>Additional Command Line</strong>: Allows additional of extra command line options to FFmpeg, default <em>-tune zerolatency</em> but is optional.</li>
               <li><strong>Debug</strong>: Show the output of ffmpeg in the log, default <em>false</em>.</li>
               <li><strong>Snapshot output</strong>: Choose how to output camera snapshot</li>
               <ul>
@@ -379,11 +379,19 @@ <h3 id="toc_4">Bridge</h3>
             bridge: {
                 value: '',
                 type: 'homekit-bridge',
-                required: false,
+                validate: function(value) {
+                    if (this.isParent == true) {
+                        return value.length > 0
+                    } else return true
+                }
             },
             parentService: {
                 value: '',
-                required: false,
+                validate: function(value) {
+                    if (this.isParent == false) {
+                        return value.length > 0
+                    } else return true
+                }
             },
             name: {
                 value: '',
@@ -478,7 +486,6 @@ <h3 id="toc_4">Bridge</h3>
             },
             cameraConfigAdditionalCommandLine: {
                 value: '-tune zerolatency',
-                validate: cameraConfigRequiredField,
             },
             cameraConfigDebug: {
                 value: false,

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "node-red-contrib-homekit-bridged",
-    "version": "1.0.3",
+    "version": "1.0.4",
     "description": "Node-RED nodes to simulate Apple HomeKit devices.",
     "main": "homekit.js",
     "scripts": {
@@ -40,8 +40,8 @@
         "eslint-config-prettier": "^6.10.0",
         "eslint-plugin-prettier": "^3.1.2",
         "husky": "^4.2.3",
-        "mocha": "^7.0.1",
-        "node-red": "^1.0.3",
+        "mocha": "^7.1.0",
+        "node-red": "^1.0.4",
         "node-red-node-test-helper": "^0.2.3",
         "prettier": "^1.19.1"
     },