Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with printing of the system #317

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

daniel-thom
Copy link
Contributor

This also changes the return type of the function get_time_series_counts, which will break parent packages, such as PowerSystems.jl.

This also changes the return type of the function
get_time_series_counts, which will break parent packages, such as
PowerSystems.jl.
@daniel-thom daniel-thom requested a review from jd-lara December 28, 2023 21:45
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2f8a2dc) 78.37% compared to head (600bfc2) 78.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   78.37%   78.14%   -0.23%     
==========================================
  Files          49       49              
  Lines        3967     3994      +27     
==========================================
+ Hits         3109     3121      +12     
- Misses        858      873      +15     
Flag Coverage Δ
unittests 78.14% <77.96%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/components.jl 90.78% <100.00%> (ø)
src/containers.jl 100.00% <100.00%> (ø)
src/supplemental_attributes.jl 78.04% <100.00%> (+3.65%) ⬆️
src/time_series_container.jl 77.19% <100.00%> (+0.40%) ⬆️
src/system_data.jl 88.79% <88.88%> (-0.19%) ⬇️
src/utils/print.jl 52.85% <64.28%> (+0.14%) ⬆️

... and 4 files with indirect coverage changes

@jd-lara jd-lara merged commit c6b7f1b into NREL-Sienna:main Jan 2, 2024
7 of 9 checks passed
@jd-lara jd-lara self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants